fix webserver healthcheck issue #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i dont get why we need curl? |
@Fraccaman The webserver service in the docker-compose.yml file has a health check block defined as follows: Copy code
healthcheck:
test: curl --fail http://localhost:5001/health || exit 1However, the webserver image does not have the curl command installed. As a result, the health check always fails, incorrectly marking the container as "unhealthy." If you inspect the webserver container, under the health key, you’ll see the corresponding health check errors. "Health": {
"Status": "unhealthy",
"FailingStreak": 42,
"Log": [
{
"Start": "2024-12-13T18:27:05.946254729+01:00",
"End": "2024-12-13T18:27:05.976298009+01:00",
"ExitCode": 1,
"Output": "/bin/sh: 1: curl: not found\n"
},
{
"Start": "2024-12-13T18:27:20.976796091+01:00",
"End": "2024-12-13T18:27:21.036034605+01:00",
"ExitCode": 1,
"Output": "/bin/sh: 1: curl: not found\n"
},
]
}To resolve this, we should either:
|
|
can you rebase on |
ignore compose override files from repository for easier customization
0x4r45h
force-pushed
the
fix/webserver-health-check
branch
from
284a83b to
bea1c9e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add curl to the webserver docker image so that the health check can be monitored correctly
ignore docker-compose.override.* files from the repository for easier customization